Skip to content

fix: Show both local and remote repo name when they differ#1547

Merged
charlesvien merged 2 commits intomainfrom
04-07-show_both_local_and_remote_repo_name_when_they_differ
Apr 9, 2026
Merged

fix: Show both local and remote repo name when they differ#1547
charlesvien merged 2 commits intomainfrom
04-07-show_both_local_and_remote_repo_name_when_they_differ

Conversation

@charlesvien
Copy link
Copy Markdown
Member

@charlesvien charlesvien commented Apr 8, 2026

Problem

Folder display names only used path.basename(), so when a local directory name differed from the GitHub repo name, the dropdown showed one name and the sidebar showed another.

Closes #1283

Changes

  1. Add getDisplayName that appends remote repo name when it differs from the local dir (e.g. ph-tour-demo (hogotchi))
  2. Extract shared normalizeRepoKey helper to strip .git suffixes consistently
  3. Use normalizeRepoKey in sidebar folder matching to fix .git suffix mismatches
  4. Use folder.name instead of group.name in sidebar labels for consistency
  5. Add four unit tests covering suffix stripping, mismatch, match and case-insensitive match

How did you test this?

Manually

@charlesvien charlesvien changed the title Show both local and remote repo name when they differ fix: Show both local and remote repo name when they differ Apr 8, 2026
@charlesvien charlesvien marked this pull request as ready for review April 8, 2026 04:18
Copy link
Copy Markdown
Contributor

@adboio adboio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if showing only the local path is better? and maybe the remote repo name can show elsewhere as needed, e.g. in github integration stuff?

not blocking just a thought!

@charlesvien charlesvien force-pushed the 04-07-show_both_local_and_remote_repo_name_when_they_differ branch 2 times, most recently from 299b4d5 to ca54136 Compare April 8, 2026 22:55
@charlesvien charlesvien force-pushed the 04-07-queue_messages_during_conversation_compaction branch from c84c3a5 to c1f0e8c Compare April 8, 2026 22:56
Copy link
Copy Markdown
Member Author

charlesvien commented Apr 8, 2026

Merge activity

  • Apr 8, 11:25 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 9, 12:09 AM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 9, 12:18 AM UTC: @charlesvien merged this pull request with Graphite.

@charlesvien charlesvien changed the base branch from 04-07-queue_messages_during_conversation_compaction to graphite-base/1547 April 9, 2026 00:01
@charlesvien charlesvien changed the base branch from graphite-base/1547 to main April 9, 2026 00:07
@charlesvien charlesvien force-pushed the 04-07-show_both_local_and_remote_repo_name_when_they_differ branch from ca54136 to 3cfc13a Compare April 9, 2026 00:08
@charlesvien charlesvien merged commit e63f693 into main Apr 9, 2026
16 checks passed
@charlesvien charlesvien deleted the 04-07-show_both_local_and_remote_repo_name_when_they_differ branch April 9, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

repo name inconsistency between task list and selector

2 participants